-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: Add rustbook/standalone doc support #31713
Conversation
This commit implements documentation generation of the nomicon, the book, the style guide, and the standalone docs. New steps were added for each one as well as appropriate makefile targets for each one as well.
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Would you like me to explore an alternate to this PR which uses mdbook instead? This is something that I've wanted to do for a long time anyway, and this new build system was what would have enabled it; maybe doing it from the start would be nice. |
It probably wouldn't really be an alternate PR but rather one to just layer on top of this. It'd just involve changing this line, perhaps this source file, and then tweaking how the tool is actually invoked (just arguments and such). Other than that, everything here will still be needed in terms of dependency tracking, freshness tracking, etc. |
Sorry, yes, "Alternate PR" was more like "I'll send a PR to this PR swapping out the bits that were specific to rustbook." |
Perhaps, we probably should do that incrementally, though. I haven't worked 100% through the flow of incorporating crates.io dependencies just yet beyond build dependencies, and I'd just want to be a little careful in doing so. |
I figured that might be it, which is why I asked. Sounds good to me, we can wait for it. |
r? @brson |
@bors r+ |
📌 Commit 848e785 has been approved by |
This commit implements documentation generation of the nomicon, the book, the style guide, and the standalone docs. New steps were added for each one as well as appropriate makefile targets for each one as well.
This commit implements documentation generation of the nomicon, the book, the
style guide, and the standalone docs. New steps were added for each one as well
as appropriate makefile targets for each one as well.